Fix UninitializedPropertyAccessException#3542
Conversation
Summary of ChangesHello @andreia-ferreira, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug where the task ViewModel could be uninitialized, leading to a crash, especially in scenarios involving process death and activity results. By shifting the ViewModel's initialization to an earlier lifecycle stage, Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively addresses an UninitializedPropertyAccessException by moving the TaskViewModel initialization from onViewCreated to onCreate. This ensures the ViewModel is available earlier in the fragment's lifecycle, preventing crashes when activity results are delivered before the view is created. The changes are logical and correctly remove the now-redundant isViewModelInitialized property and its related checks. I have one minor suggestion for code conciseness.
app/src/main/java/org/groundplatform/android/ui/datacollection/tasks/AbstractTaskFragment.kt
Outdated
Show resolved
Hide resolved
andreia-ferreira
had a problem deploying
to
e2e-approval
GitHub Actions
Error
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3542 +/- ##
=========================================
Coverage 70.62% 70.62%
Complexity 1621 1621
=========================================
Files 327 327
Lines 8889 8889
Branches 982 982
=========================================
Hits 6278 6278
Misses 2023 2023
Partials 588 588 🚀 New features to boost your workflow:
|
andreia-ferreira
temporarily deployed
to
e2e-approval
GitHub Actions
Inactive
2 participants
Fixes #3517
The task VM was initialized in
onViewCreated, butPhotoTaskFragment, for example, registers itscapturePhotoLauncherinonCreate. If the activity result fired before the view attached (e.g. after process death while the camera was open), the VM would be uninitialized, causing the UninitializedPropertyAccessException.This PR moves the task VM initialization to
by lazy. This should should be safe since the taskId is available at that point (set by either the parent adapter or restored from the saved instance) and if the task fragment is initalized it means that the data collection VM is also on a ready state.before:
Screen_recording_20260211_182658.webm
after:
Screen_recording_20260211_182439.webm
@shobhitagarwal1612 PTAL?